Allow annotations in ray cluster helm chart #574
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extra annotations on the RayCluster custom resource are needed to enable functions like GCS FT for a Ray cluster. These annotations should be configurable in the Helm chart without editing the `raycluster-cluster.yaml` template. Signed-off-by: Sigmund Vestergaard <sigmundv@gmail.com>
We only want to add an annotations block if it is specified in values.yaml Signed-off-by: Sigmund Vestergaard <sigmundv@gmail.com>
|
@kevin85421 could you help review this PR? |
Jeffwan
approved these changes
Oct 11, 2022
lowang-bh
pushed a commit
to lowang-bh/kuberay
that referenced
this pull request
Sep 24, 2023
* Allow annotations in RayCluster CR Extra annotations on the RayCluster custom resource are needed to enable functions like GCS FT for a Ray cluster. These annotations should be configurable in the Helm chart without editing the `raycluster-cluster.yaml` template. Signed-off-by: Sigmund Vestergaard <sigmundv@gmail.com> * Only render annotations if they are set We only want to add an annotations block if it is specified in values.yaml Signed-off-by: Sigmund Vestergaard <sigmundv@gmail.com> Signed-off-by: Sigmund Vestergaard <sigmundv@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Extra annotations on the RayCluster custom resource are needed to enable functions like GCS FT for a Ray cluster. These annotations should be configurable in the Helm chart without editing the
raycluster-cluster.yamltemplate.Related issue number
I couldn't find any related issue.
Checks