Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Doc] Cannot build kuberay with Go 1.16 #575

Merged
merged 2 commits into from
Sep 16, 2022

Conversation

kevin85421
Copy link
Member

Why are these changes needed?

See #568.

Related issue number

Closes #568

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • This PR is not tested :(

Copy link
Collaborator

@DmitriGekhtman DmitriGekhtman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nits


### Setup on Kind

For a local [kind](https://kind.sigs.k8s.io/) environment setup, you can follow the Jupyter Notebook example: [KubeRay-on-kind](../docs/notebook/kuberay-on-kind.ipynb).

### Use go v1.17

Currently, Kuberay does not support go v1.16 ([#568](https://github.com/ray-project/kuberay/issues/568)) and go v1.18 ([#518](https://github.com/ray-project/kuberay/issues/518)).
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Grammar nit:
and -> or because there's a negation (not)

It's as if English grammar follows De Morgan's law... but actually English grammar is just plain bizarre.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, I just wrote the sentence with De Morgan's law lol. Thank you for letting me know. Updated.

ray-operator/DEVELOPMENT.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@DmitriGekhtman DmitriGekhtman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@DmitriGekhtman DmitriGekhtman merged commit 44ff72c into ray-project:master Sep 16, 2022
lowang-bh pushed a commit to lowang-bh/kuberay that referenced this pull request Sep 24, 2023
Updates Development docs to indicate the KubeRay build currently requires Go 1.17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Cannot build kuberay with Go 1.16
2 participants