Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bugfix][apiserver helm]: Adding missing rbacenable value #594

Merged
merged 1 commit into from
Sep 27, 2022
Merged

[bugfix][apiserver helm]: Adding missing rbacenable value #594

merged 1 commit into from
Sep 27, 2022

Conversation

dhaval0108
Copy link
Contributor

@dhaval0108 dhaval0108 commented Sep 27, 2022 •
edited

Why are these changes needed?

The rbacEnable value is being checked here to apply the default role and rolebinding. However, the value was missing from the values.yaml.

Related issue number

None

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • This PR is not tested :(

@DmitriGekhtman
Copy link
Collaborator

DmitriGekhtman commented Sep 27, 2022 •
edited

Thanks for the fix!
It looks like we're changing the default behavior to be enable creation of RBAC. That makes sense to me as the default.
@scarlet25151 @Jeffwan @kevin85421 does the change in behavior look good to you?

scarlet25151
scarlet25151 approved these changes Sep 27, 2022
View reviewed changes
Copy link
Collaborator

@scarlet25151 scarlet25151 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Default RBAC of apiserver LGTM.

@DmitriGekhtman
Copy link
Collaborator

The lint failure is concerning, but it's unrelated. Helm checks pass, so it's good to merge.

DmitriGekhtman
DmitriGekhtman approved these changes Sep 27, 2022
View reviewed changes
Copy link
Collaborator

@DmitriGekhtman DmitriGekhtman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@DmitriGekhtman DmitriGekhtman merged commit 9ee2383 into ray-project:master Sep 27, 2022
@dhaval0108
Copy link
Contributor Author

Thank you for the review! Hope this helps

lowang-bh pushed a commit to lowang-bh/kuberay that referenced this pull request Sep 24, 2023
@dhaval0108
[bugfix][apiserver helm]: Adding missing rbacenable value (ray-projec…
2fcd5e8 
…t#594)

The rbacEnable value is check in the API server's Helm templat to apply the default role and rolebinding. However, the value was missing from the values.yaml.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scarlet25151 scarlet25151 scarlet25151 approved these changes

@DmitriGekhtman DmitriGekhtman DmitriGekhtman approved these changes

@Jeffwan Jeffwan Awaiting requested review from Jeffwan

@kevin85421 kevin85421 Awaiting requested review from kevin85421

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dhaval0108 @DmitriGekhtman @scarlet25151