Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature][Doc] Explain that RBAC should be synchronized manually #641

Merged
merged 1 commit into from
Oct 17, 2022
Merged

[Feature][Doc] Explain that RBAC should be synchronized manually #641

merged 1 commit into from
Oct 17, 2022

Conversation

kevin85421
Copy link
Member

Why are these changes needed?

Currently, RBAC YAML files in helm-chart/kuberay-operator/templates and ray-operator/config/rbac should be synchronized manually. We have pointed this out in DEVELOPMENT.md, but it is not easy for users to find the messages. Hence, we need to make this information become more explicit in both DEVELOPMENT.md and rbac-check.py.

Related issue number

Closes #640
#631

Checks

# Step1: Make `helm-chart/kuberay-operator/templates` and `ray-operator/config/rbac` inconsistent.
# Step2: (in `tests/`)
python3 ../scripts/rbac-check.py
  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • This PR is not tested :(

@DmitriGekhtman DmitriGekhtman changed the title [Feature][Doc] RBAC should be synchronized manually [Feature][Doc] Explain that RBAC should be synchronized manually Oct 17, 2022
DmitriGekhtman
DmitriGekhtman approved these changes Oct 17, 2022
View reviewed changes
Copy link
Collaborator

@DmitriGekhtman DmitriGekhtman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, lgtm.

@DmitriGekhtman DmitriGekhtman merged commit f4b2823 into ray-project:master Oct 17, 2022
lowang-bh pushed a commit to lowang-bh/kuberay that referenced this pull request Sep 24, 2023
@kevin85421
[Feature][Doc] Explain that RBAC should be synchronized manually (ray…
2425232 
…-project#641)

Currently, RBAC YAML files in helm-chart/kuberay-operator/templates and ray-operator/config/rbac should be synchronized manually. We have pointed this out in DEVELOPMENT.md, but it is not easy for users to find the messages. Hence, we need to make this information become more explicit in both DEVELOPMENT.md and rbac-check.py.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DmitriGekhtman DmitriGekhtman DmitriGekhtman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature][Doc] Explain that RBAC should be synchronized manually
2 participants
@kevin85421 @DmitriGekhtman