[Feature][Docs] AWS Application Load Balancer (ALB) support #658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DmitriGekhtman
approved these changes
Oct 27, 2022
Co-authored-by: Dmitri Gekhtman <62982571+DmitriGekhtman@users.noreply.github.com> Signed-off-by: Kai-Hsun Chen <kaihsun@apache.org>
Co-authored-by: Dmitri Gekhtman <62982571+DmitriGekhtman@users.noreply.github.com> Signed-off-by: Kai-Hsun Chen <kaihsun@apache.org>
Co-authored-by: Dmitri Gekhtman <62982571+DmitriGekhtman@users.noreply.github.com> Signed-off-by: Kai-Hsun Chen <kaihsun@apache.org>
Co-authored-by: Dmitri Gekhtman <62982571+DmitriGekhtman@users.noreply.github.com> Signed-off-by: Kai-Hsun Chen <kaihsun@apache.org>
2 tasks
lowang-bh
pushed a commit
to lowang-bh/kuberay
that referenced
this pull request
Sep 24, 2023
…ect#658) * Update docs/guidance/ingress.md Co-authored-by: Dmitri Gekhtman <62982571+DmitriGekhtman@users.noreply.github.com> Signed-off-by: Kai-Hsun Chen <kaihsun@apache.org> Adds docs on how to set up an ingress for KubeRay on EKS using an ALB.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Some users are interested in ingress support of KubeRay. KubeRay has built-in ingress support. However, built-in ingress only supports simple Nginx setups (See ingress.md#example-nginx-ingress-on-kind and #646 for more details). We do not recommend users use built-in ingress support in a production environment with complex routing requirements. Hence, we need to have more documentation about how to set up ingress without built-in ingress support.
AWS Application Load Balancer (ALB) is one of the most popular ingress controllers. It is good to have a document to describe how to set up ALB as an ingress controller and a load balancer for KubeRay.
Why do not we recommend users use built-in ingress support in a production environment?
rewrite-target, and thus the built-in ingress support can support it. See [Bug] Fail to create ingress due to the deprecation of the ingress.class annotation #646 for more details. However, ALB does not supportrewrite-targetfeature (URL rewrite? kubernetes-sigs/aws-load-balancer-controller#835), and thus it is hard to support it with the built-in ingress support.Related issue number
Closes #657
#441
Checks
Screenshot
Access Ray Dashboard with the DNS name of the ALB.
