Fix duplicated volume issue #690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jeffwan
approved these changes
Nov 5, 2022
kevin85421
previously requested changes
Nov 5, 2022
|
confirmed by Yi Cheng that this issue is no longer observed. cc @iycheng |
wilsonwang371
force-pushed
the
wilson/dup-volume-fix
branch
from
4969e91
to
e0de9f7
Compare
wilsonwang371
force-pushed
the
wilson/dup-volume-fix
branch
from
e0de9f7
to
fb1f485
Compare
DmitriGekhtman
approved these changes
Nov 8, 2022
kevin85421
reviewed
Nov 8, 2022
There was a problem hiding this comment.
Thank @wilsonwang371 for the update! Can you rebase the branch? I have added some config tests in the latest commit. In addition, unit tests appreciated. Thank you!
wilsonwang371
force-pushed
the
wilson/dup-volume-fix
branch
from
fb1f485
to
80b5290
Compare
DmitriGekhtman
requested changes
Nov 8, 2022
wilsonwang371
commented
Nov 8, 2022
|
@wilsonwang371 this will be good to merge after a basic unit test is added |
DmitriGekhtman
approved these changes
Nov 10, 2022
wilsonwang371
force-pushed
the
wilson/dup-volume-fix
branch
from
7155d0c
to
266b9b3
Compare
wilsonwang371
changed the title
wilsonwang371
force-pushed
the
wilson/dup-volume-fix
branch
from
266b9b3
to
152b4a4
Compare
kevin85421
approved these changes
Nov 10, 2022
|
@wilsonwang371 is it ready to merge? The PR title is "WIP". Thank you! |
DmitriGekhtman
changed the title
|
Deleted the WIP :) . Merging. |
this is really fast..... i was thinking about a few more tests... although it is fine to merge now... |
|
My bad! Sometimes I'm a bit trigger happy. |
4 tasks
lowang-bh
pushed a commit
to lowang-bh/kuberay
that referenced
this pull request
Sep 24, 2023
Avoid duplicating volumeMount paths.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
some corner cases can be triggered and the error below is returned
Related issue number
#688
Checks