Adding example of manually setting up NGINX Ingress #699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Hsin-Yuan Chen <35865970+jasoonn@users.noreply.github.com>
Signed-off-by: Hsin-Yuan Chen <35865970+jasoonn@users.noreply.github.com>
kevin85421
reviewed
Nov 8, 2022
Signed-off-by: Hsin-Yuan Chen <35865970+jasoonn@users.noreply.github.com>
Signed-off-by: Hsin-Yuan Chen <35865970+jasoonn@users.noreply.github.com>
Signed-off-by: Hsin-Yuan Chen <35865970+jasoonn@users.noreply.github.com>
Signed-off-by: Hsin-Yuan Chen <35865970+jasoonn@users.noreply.github.com>
|
@kevin85421 Thanks for your suggestion. I have updated my pr. |
Co-authored-by: Dmitri Gekhtman <62982571+DmitriGekhtman@users.noreply.github.com> Signed-off-by: Hsin-Yuan Chen <35865970+jasoonn@users.noreply.github.com>
Co-authored-by: Dmitri Gekhtman <62982571+DmitriGekhtman@users.noreply.github.com> Signed-off-by: Hsin-Yuan Chen <35865970+jasoonn@users.noreply.github.com>
|
@DmitriGekhtman Thanks for the suggestion. I have updated my pr. |
kevin85421
approved these changes
Nov 9, 2022
There was a problem hiding this comment.
LGTM. Let's wait for CI to finish. Thank @jasoonn for this contribution!
2 tasks
4 tasks
lowang-bh
pushed a commit
to lowang-bh/kuberay
that referenced
this pull request
Sep 24, 2023
This example provides users a starting point to customize their own ingress for ray clusters. ray-cluster.separate-ingress.yaml provides a template for setting up a ray cluster and the corresponding ingress, which clearly shows the relationship between ray cluster and ingress. Signed-off-by: Hsin-Yuan Chen <35865970+jasoonn@users.noreply.github.com> Co-authored-by: Ubuntu <azureuser@Ubuntu.pqxb1uggpgbehcpt4orv5untcb.rx.internal.cloudapp.net> Co-authored-by: Dmitri Gekhtman <62982571+DmitriGekhtman@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
This example provides users a starting point to customize their own ingress for ray clusters. ray-cluster.separate-ingress.yaml provides a template for setting up a ray cluster and the corresponding ingress, which clearly shows the relationship between ray cluster and ingress.
Information helpful for modifying the ingress in ray-cluster.separate-ingress.yaml
spec.rules.http.paths.backend.service.nameshould be the same as head servicespec.rules.http.paths.backend.service.port.numbershould match the port specified for dashboard in the RayClustermetadata.annotations.nginx.ingress.kubernetes.io/rewrite-target: /$1Any characters captured by (.*) will be assigned to the placeholder $1, which is then used as a parameter in the rewrite-target annotation(rewrite-target doc)
For example, the ingress definition above will result in the following rewrites:
$IP/$CLUSTER_NAME/rewrites to$IP/($1 maps to nothing)$IP/$CLUSTER_NAME/#/actorsrewrites to$IP/#/actors($1 maps to #/actors)$IP/$CLUSTER_NAME/#/noderewrites to$IP/#/node($1 maps to #/node)Related issue number
#646
Demo
Step 1: Create kind cluster, for more reference can see in here.
Step 2: Install NGINX ingress controller
Step 3: Install KubeRay operator
Step 4: Install RayCluster and create an ingress separately.
Step 5: Check ingress created by Step 4.
Step 6: Check
<ip>/raycluster-ingress/on the browser.Checks