[fix][raycluster controller] No error if head ip cannot be determined. #701
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dmitri Gekhtman <dmitri.m.gekhtman@gmail.com>
kevin85421
reviewed
Nov 9, 2022
ray-operator/controllers/ray/raycluster_controller_fake_test.go
Outdated
Show resolved
Hide resolved
Signed-off-by: Dmitri Gekhtman <dmitri.m.gekhtman@gmail.com>
Signed-off-by: Dmitri Gekhtman <dmitri.m.gekhtman@gmail.com>
lowang-bh
pushed a commit
to lowang-bh/kuberay
that referenced
this pull request
Sep 24, 2023
ray-project#701) This PR modifies headIP status logic to be best effort -- if the IP cannot be determined, it is recorded as an empty string. Signed-off-by: Dmitri Gekhtman <dmitri.m.gekhtman@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Dmitri Gekhtman dmitri.m.gekhtman@gmail.com
Why are these changes needed?
#468 has the RayCluster controller throw an error if head ip can't be determined while updating RayCluster status
That is problematic for two reasons:
Throwing an error in the first situation might be leading to test failures:
https://github.com/ray-project/kuberay/actions/runs/3424423296/jobs/5706807752
This PR modifies the headIP status logic to be best effort -- if the IP cannot be determined, it is recorded as an empty string.
cc @davidxia
Related issue number
#468
Checks