[Autoscaler] Pass pod name to autoscaler, add pod patch permission #740
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dmitri Gekhtman <dmitri.m.gekhtman@gmail.com>
DmitriGekhtman
changed the title
6 tasks
|
Corresponding Ray PR is here: |
wuisawesome
approved these changes
Nov 21, 2022
lowang-bh
pushed a commit
to lowang-bh/kuberay
that referenced
this pull request
Sep 24, 2023
This commit gives the autoscaler: Access to the name of the pod it's running in, via an env variable Permission to patch the head pod Signed-off-by: Dmitri Gekhtman <dmitri.m.gekhtman@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
I'd like to give the autoscaler
The goal is to enable more efficient "list pods" API calls in the autoscaler. Currently each autoscaler lists without specifying a resource version, which is taxing on etcd, especially if there are many Ray clusters in the K8s cluster.
We would like to specify a reasonably fresh pods resource version in the API call.
To that end, we will have the autoscaler patch the head pod's annotations.
The resource version carried in the response is the version at which the pod was modified, so it should be fresh enough.
After the autoscaler patches the head pod, it can read the resourceVersion in the response and use that in the list query.
Related issue number
Checks