Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Release] Update docs for release v0.4.0 #779

Merged
merged 6 commits into from
Dec 3, 2022

Conversation

kevin85421
Copy link
Member

@kevin85421 kevin85421 commented Dec 2, 2022

Why are these changes needed?

Related issue number

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • This PR is not tested :(

@kevin85421
Copy link
Member Author

@scarlet25151 would you mind writing a development guide for APIServer and adding the guide to development.md#develop-kuberay-apiserver? If you are busy, we can create an issue to track the progress. Thank you!

@scarlet25151
Copy link
Collaborator

@scarlet25151 would you mind writing a development guide for APIServer and adding the guide to development.md#develop-kuberay-apiserver? If you are busy, we can create an issue to track the progress. Thank you!

Hi @kevin85421 thank you for your suggestions, here we've added the DEVELOPMENT.md docs for apiserver in https://github.com/ray-project/kuberay/pull/778/files#diff-f2d8dab7dc054250560f0413fa948a52fd11928ed08923a0c9a239d0837bae00, and we may combine them together?

@kevin85421
Copy link
Member Author

Thank @scarlet25151! I have added the link to development.md.

@kevin85421
Copy link
Member Author

@DmitriGekhtman I did not have any context related to ArgoCD. What's the priority of reviewing kuberay-operator/README.md#working-with-argo-cd? Thank you!

@DmitriGekhtman
Copy link
Collaborator

@DmitriGekhtman I did not have any context related to ArgoCD. What's the priority of reviewing kuberay-operator/README.md#working-with-argo-cd? Thank you!

I wouldn't worry about it. If we get questions about this, we can ping the author.

@kevin85421 kevin85421 marked this pull request as ready for review December 3, 2022 01:39
Copy link
Collaborator

@DmitriGekhtman DmitriGekhtman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me, thanks!

@DmitriGekhtman DmitriGekhtman merged commit 855358b into ray-project:master Dec 3, 2022
lowang-bh pushed a commit to lowang-bh/kuberay that referenced this pull request Sep 24, 2023
Update a few pages of documentation for release v0.4.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants