Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Pin go version in CRD consistency check #794

Merged

Conversation

DmitriGekhtman
Copy link
Collaborator

Signed-off-by: Dmitri Gekhtman dmitri.m.gekhtman@gmail.com

Why are these changes needed?

Related issue number

Closes #791, which occurred due to CRD consistency job's automatic choice of an incompatible Go version (1.18.x).

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • This PR is not tested :(

Signed-off-by: Dmitri Gekhtman <dmitri.m.gekhtman@gmail.com>
@DmitriGekhtman
Copy link
Collaborator Author

Affected test fixed, rest of the tests unaffected. Merging before CI completion.

@DmitriGekhtman DmitriGekhtman merged commit 39a8480 into ray-project:master Dec 6, 2022
DmitriGekhtman added a commit to DmitriGekhtman/kuberay that referenced this pull request Dec 6, 2022
Pin Go 1.17 in CRD consistency check.

Signed-off-by: Dmitri Gekhtman <dmitri.m.gekhtman@gmail.com>
DmitriGekhtman added a commit that referenced this pull request Dec 6, 2022
Pin Go 1.17 in CRD consistency check.

Signed-off-by: Dmitri Gekhtman <dmitri.m.gekhtman@gmail.com>
lowang-bh pushed a commit to lowang-bh/kuberay that referenced this pull request Sep 24, 2023
Pin Go 1.17 in CRD consistency check.

Signed-off-by: Dmitri Gekhtman <dmitri.m.gekhtman@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] ray-operator-verify-crd-rbac is broken in master
2 participants