Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[post-0.4.0 KubeRay release] Update KubeRay versions #821

Merged

Conversation

DmitriGekhtman
Copy link
Collaborator

Signed-off-by: Dmitri Gekhtman dmitri.m.gekhtman@gmail.com

Why are these changes needed?

Updates KubeRay versions in master.
To be merged after images and Helm charts are built.

Related issue number

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • This PR is not tested :(

Signed-off-by: Dmitri Gekhtman <dmitri.m.gekhtman@gmail.com>
@DmitriGekhtman
Copy link
Collaborator Author

@Jeffwan @scarlet25151 I did not modify KubeRay versions in files related to the CLI or API server.
That's up to you guys.

Copy link
Collaborator

@scarlet25151 scarlet25151 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall LGTM.

@DmitriGekhtman
Copy link
Collaborator Author

DmitriGekhtman commented Dec 9, 2022

@sihanwang41 can make the call on when to merge this.

version: 0.3.0

# This is the version number of the application being deployed. This version number should be
# incremented each time you make changes to the application. Versions are not expected to
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to use helm version to track the upgrade in future?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you elaborate?

The version field is still there.

@Jeffwan
Copy link
Collaborator

Jeffwan commented Dec 9, 2022

I add ci bot back and let's check how the CI works

@Jeffwan Jeffwan merged commit 0c16aa6 into ray-project:master Dec 9, 2022
@Jeffwan
Copy link
Collaborator

Jeffwan commented Dec 9, 2022

@scarlet25151 Please update the apiserver versions in a follow up PR.

lowang-bh pushed a commit to lowang-bh/kuberay that referenced this pull request Sep 24, 2023
Signed-off-by: Dmitri Gekhtman <dmitri.m.gekhtman@gmail.com>

Signed-off-by: Dmitri Gekhtman <dmitri.m.gekhtman@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants