Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] error: git cmd when following docs #831

Merged
merged 2 commits into from
Dec 10, 2022

Conversation

kevin85421
Copy link
Member

Why are these changes needed?

See #288 (comment) for more details.

  • I can reproduce this issue with kubectl v1.21.0
$ kubectl create -k "github.com/ray-project/kuberay/manifests/cluster-scope-resources?ref=${KUBERAY_VERSION}&timeout=90s"
error: git cmd = '/usr/local/bin/git fetch --depth=1 origin v0.3.0&timeout=90s': exit status 128

$ kubectl version --client=true --short=true
Client Version: v1.21.0
  • Fix this issue by updating kubectl to v1.22.0+
$ kubectl create -k "github.com/ray-project/kuberay/manifests/cluster-scope-resources?ref=${KUBERAY_VERSION}&timeout=90s"
namespace/ray-system created
customresourcedefinition.apiextensions.k8s.io/rayclusters.ray.io created
customresourcedefinition.apiextensions.k8s.io/rayjobs.ray.io created
customresourcedefinition.apiextensions.k8s.io/rayservices.ray.io created

$ kubectl version --client=true --short=true
Client Version: v1.22.0
  • You can upgrade your kubectl by the following commands
curl -LO "https://dl.k8s.io/release/v1.22.0/bin/darwin/amd64/kubectl"
chmod +x kubectl
sudo cp kubectl $YOUR_PATH

Related issue number

Closes #288

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • This PR is not tested :(

@kevin85421
Copy link
Member Author

cc @tekumara

@DmitriGekhtman
Copy link
Collaborator

Thanks for finding the root cause here.

If you using an earlier K8s client version, you can achieve the desired effect by pulling the 0.4.0 branch and creating the
K8s objects from the local configs.
Would you mind expressing that info here?

@kevin85421
Copy link
Member Author

Thanks for finding the root cause here.

If you using an earlier K8s client version, you can achieve the desired effect by pulling the 0.4.0 branch and creating the K8s objects from the local configs. Would you mind expressing that info here?

Thank you for your review! Updated.

@DmitriGekhtman DmitriGekhtman merged commit 1186737 into ray-project:master Dec 10, 2022
lowang-bh pushed a commit to lowang-bh/kuberay that referenced this pull request Sep 24, 2023
Add more fine-grained Kubernetes and Helm version details to installation instructions.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] error: git cmd when following docs
2 participants