Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Release] Add tools and docs for changelog generator #833

Merged
merged 1 commit into from
Dec 11, 2022

Conversation

Jeffwan
Copy link
Collaborator

@Jeffwan Jeffwan commented Dec 11, 2022

Why are these changes needed?

Add tools and docs for changelog generator

Related issue number

#832

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • [] Unit tests
    • Manual tests
    • This PR is not tested :(

Copy link
Collaborator

@DmitriGekhtman DmitriGekhtman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this is super helpful!

@DmitriGekhtman DmitriGekhtman merged commit 865affa into ray-project:master Dec 11, 2022
@DmitriGekhtman DmitriGekhtman changed the title Add tools and docs for changelog generator [Release] Add tools and docs for changelog generator Dec 11, 2022
83aab82 [CI] Pin go version in CRD consistency check (#794) (#797)
'''

g = ChangelogGenerator("kubeflow/training-operator")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ray-project/kuberay?

Copy link
Collaborator Author

@Jeffwan Jeffwan Dec 12, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch. I forget to update the repo name. I will file a separate PR to address it


1. Prepare your Github Token

1. Install Github python dependencies to generate changlog
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2?

git log v0.3.0..v0.4.0 --oneline
```

1. Copy above commit history to `scripts/changelog-generator.py` and replace `<your_github_token>` with your Github token. Run the python scripts to generate changelogs.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2?

pr_id = int(pr_match.group(1))
print("* {}".format(g.generate(pr_id)))
```
1. You probably need to update the commit logs if it contains tag information or additional PRs links.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3?

- c1cbaed (tag: v0.4.0-rc.0) Update chart versions for 0.4.0-rc.0 (#804) -> c1cbaed Update chart versions for 0.4.0-rc.0 (#804)
- 86b0af2 Remove ingress.enabled from KubeRay operator chart (#812) (#816) -> 86b0af2 Remove ingress.enabled from KubeRay operator chart (#816)

1. Cut release from tags and copy results from last step. You can group commits into `Features`, `Bugs` etc and add to release notes.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

4?

1. Cut release from tags and copy results from last step. You can group commits into `Features`, `Bugs` etc and add to release notes.
See example [v0.3.0 release](https://github.com/ray-project/kuberay/releases/tag/v0.3.0)

1. Send a PR to update [CHANGELOG.md](https://github.com/ray-project/kuberay/blob/master/CHANGELOG.md)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

5?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mkdocs generates correct numbers for the website, but it does look bizarre in the readme

I will address your comments in a follow-up --
(I'm on a plane with nothing to do :) )

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kevin85421
Copy link
Member

We can also add the link about creating personal GitHub access token.

@Jeffwan
Copy link
Collaborator Author

Jeffwan commented Dec 12, 2022

@kevin85421

Using multiple 1 is a magic to auto rank the number. This is to avoid additional changes for example you delete one line in the middle and you need to rewrite all numbers.

@Jeffwan Jeffwan deleted the jiaxin/changelog_scripts branch December 12, 2022 00:29
@DmitriGekhtman
Copy link
Collaborator

@kevin85421

Using multiple 1 is a magic to auto rank the number. This is to avoid additional changes for example you delete one line in the middle and you need to rewrite all numbers.

Ah, that makes sense. Just looks a little funky when reading the raw file.

1 similar comment
@DmitriGekhtman
Copy link
Collaborator

@kevin85421

Using multiple 1 is a magic to auto rank the number. This is to avoid additional changes for example you delete one line in the middle and you need to rewrite all numbers.

Ah, that makes sense. Just looks a little funky when reading the raw file.

lowang-bh pushed a commit to lowang-bh/kuberay that referenced this pull request Sep 24, 2023
Add tools and docs for release changelog generator.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants