Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

match selector of service to pod labels #918

Merged
merged 1 commit into from
Feb 23, 2023
Merged

match selector of service to pod labels #918

merged 1 commit into from
Feb 23, 2023

Conversation

akihikokuroda
Copy link
Contributor

@akihikokuroda akihikokuroda commented Feb 21, 2023 •
edited
Loading

Why are these changes needed?

The selector in the kuberay-apiserver service doesn't match the label of the kuberay-apiserver. So the kuberay-apiserver can not be accessed via the the kuberay-apiserver service.
Pod labels:

      app.kubernetes.io/component: kuberay-apiserver
      app.kubernetes.io/name: ccccc
      pod-template-hash: 69b79f99c5

Service selector

      app.kubernetes.io/name: kuberay-apiserver

This PR changes the service selector to match the apiserver pod labels in the helm template.

Related issue number

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • This PR is not tested :(

@akihikokuroda
match selector pf service to pod labels
881b285 
Signed-off-by: akihikokuroda <akihikokuroda2020@gmail.com>
@akihikokuroda akihikokuroda changed the title match selector pf service to pod labels match selector of service to pod labels Feb 22, 2023
Jeffwan
Jeffwan approved these changes Feb 22, 2023
View reviewed changes
Copy link
Collaborator

@Jeffwan Jeffwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix! It's indeed a problem in helm chart.

@Jeffwan Jeffwan merged commit 5876b1d into ray-project:master Feb 23, 2023
@akihikokuroda akihikokuroda mentioned this pull request Feb 24, 2023
Merged
@akihikokuroda akihikokuroda deleted the serviceselector branch February 24, 2023 14:57
@akihikokuroda
Copy link
Contributor Author

@Jeffwan Thanks! We can take out this workaround from the README

@psschwei psschwei mentioned this pull request Mar 9, 2023
Closed
lowang-bh pushed a commit to lowang-bh/kuberay that referenced this pull request Sep 24, 2023
@akihikokuroda
match selector pf service to pod labels (ray-project#918)
6751a0d 
Signed-off-by: akihikokuroda <akihikokuroda2020@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jeffwan Jeffwan Jeffwan approved these changes

@scarlet25151 scarlet25151 Awaiting requested review from scarlet25151

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@akihikokuroda @Jeffwan