Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add sidecar container option #920

Merged
merged 1 commit into from
Feb 24, 2023
Merged

Conversation

akihikokuroda
Copy link
Contributor

@akihikokuroda akihikokuroda commented Feb 22, 2023

Why are these changes needed?

The sidecar container is useful for adding security capabilities to the pod. This PR adds the capability to inject the sidecar container to the api-server pod by the values.yaml file.

Related issue number

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • This PR is not tested :(

Signed-off-by: akihikokuroda <akihikokuroda2020@gmail.com>
@Jeffwan
Copy link
Collaborator

Jeffwan commented Feb 22, 2023

Thanks for the contribution. Do you mind sharing an example? I am thinking we should document these customization just in case someone want to use this configuration as well

@akihikokuroda
Copy link
Contributor Author

@Jeffwan Thanks for review! This is putting the same sidecar capability as the ray head / worker node

{{- if .Values.head.sidecarContainers }}
. I can provide a sample soon.

@akihikokuroda
Copy link
Contributor Author

Here is the value file example. This works with Keycloak configured for "Client Credentials Grant" in OAuth2 specification.

sidecarContainers:
  - image: quay.io/gogatekeeper/gatekeeper:2.1.1
    imagePullPolicy: IfNotPresent
    name: gatekeeper
    args:
    - --no-redirects=true
    - --forwarding-grant-type=client_credentials
    - --listen=0.0.0.0:4180
    - --client-id=rayapiserver
    - --client-secret=APISERVERSECRET-CHANGEME
    - --discovery-url=http://LOCAL-IP:31059/realms/quantumserverless
    - --enable-logging=true
    - --verbose=true
    - --upstream-url=http://kuberay-apiserver-service:8888/

@Jeffwan Jeffwan merged commit 65bb861 into ray-project:master Feb 24, 2023
@akihikokuroda akihikokuroda deleted the sidecar branch February 24, 2023 14:53
@akihikokuroda
Copy link
Contributor Author

@Jeffwan Thanks for your approval. This change will be used in Qiskit/qiskit-serverless#235

lowang-bh pushed a commit to lowang-bh/kuberay that referenced this pull request Sep 24, 2023
Signed-off-by: akihikokuroda <akihikokuroda2020@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants