[Feature] The default ImagePullPolicy should be IfNotPresent #947
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Although we have
autoscalerOptions.imagePullPolicy
to overwrite the defaultimagePullPolicy
(Always) in Autoscaler, there are still some reasons to update the default value forimagePullPolicy
.No Ray image with the tag
latest
is used in KubeRay. In that case, the default image pull policy for Pod should beIfNotPresent
. See this doc for more details.The default image pull policies for head Pod and worker Pods are
IfNotPresent
, but the default image pull policy isAlways
.https://github.com/ray-project/ray/tree/master/python/ray/tests/kuberay => With this PR, we can run the tests locally without updating any line of code.
Related issue number
Closes #890
Checks
With this PR
Without this PR