Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add rayVersion in the RayCluster chart #975

Merged
merged 3 commits into from
Mar 27, 2023
Merged

Add rayVersion in the RayCluster chart #975

merged 3 commits into from
Mar 27, 2023

Conversation

Yicheng-Lu-llll
Copy link
Contributor

Why are these changes needed?

See #931

Related issue number

Closes #931

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • This PR is not tested :(

@Yicheng-Lu-llll Yicheng-Lu-llll force-pushed the NoRayVersionInTheRayClusterChart branch from 581577b to 43369c2 Compare March 18, 2023 21:10
@Yicheng-Lu-llll
add rayVersion in the RayCluster chart
11151b4 
Signed-off-by: Yicheng-Lu-llll <luyc58576@gmail.com>
@Yicheng-Lu-llll Yicheng-Lu-llll force-pushed the NoRayVersionInTheRayClusterChart branch from 43369c2 to 11151b4 Compare March 18, 2023 21:12
@kevin85421 kevin85421 self-requested a review March 20, 2023 23:29
@Yicheng-Lu-llll Yicheng-Lu-llll changed the title [WIP] Add rayVersion in the RayCluster chart Add rayVersion in the RayCluster chart Mar 20, 2023
@Yicheng-Lu-llll Yicheng-Lu-llll marked this pull request as ready for review March 20, 2023 23:58
@Yicheng-Lu-llll
improve comment
f63bf6f 
Signed-off-by: Yicheng-Lu-llll <luyc58576@gmail.com>
@Yicheng-Lu-llll
remove temp file
928684d 
Signed-off-by: Yicheng-Lu-llll <luyc58576@gmail.com>
kevin85421
kevin85421 approved these changes Mar 27, 2023
View reviewed changes
Copy link
Member

@kevin85421 kevin85421 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

# Uncomment `rayVersion` in values.yaml
helm template . | grep rayVersion
# rayVersion: 2.3.0

Screen Shot 2023-03-27 at 2 49 10 PM

@kevin85421 kevin85421 merged commit 7856027 into ray-project:master Mar 27, 2023
lowang-bh pushed a commit to lowang-bh/kuberay that referenced this pull request Sep 24, 2023
@Yicheng-Lu-llll
Add rayVersion in the RayCluster chart (ray-project#975)
c047b47 
Add rayVersion in the RayCluster chart
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevin85421 kevin85421 kevin85421 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] No rayVersion in the RayCluster chart
2 participants
@Yicheng-Lu-llll @kevin85421