Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify checkpointing callback for Ray Train/Tune integration #53

Merged
merged 12 commits into from
Feb 4, 2024

Conversation

justinvyu
Copy link
Contributor

@justinvyu justinvyu commented Dec 27, 2023

This PR simplifies the Ray Train/Tune integration for lightgbm_ray by doing the following:

  • Removes the deprecated APIs (TuneReportCallback, is_session_enabled, callback._report, callback._checkpoint)
  • Unifies the checkpointing integration with Tune around TuneReportCheckpointCallback
  • Uses the public ray.train.get_context API instead of detecting the train "session"

Related PR on the main ray repo: ray-project/ray#42111

Signed-off-by: Justin Yu <justinvyu@anyscale.com>
Signed-off-by: Justin Yu <justinvyu@anyscale.com>
Signed-off-by: Justin Yu <justinvyu@anyscale.com>
Signed-off-by: Justin Yu <justinvyu@anyscale.com>
Signed-off-by: Justin Yu <justinvyu@anyscale.com>
Signed-off-by: Justin Yu <justinvyu@anyscale.com>
Signed-off-by: Justin Yu <justinvyu@anyscale.com>
Signed-off-by: Justin Yu <justinvyu@anyscale.com>
Signed-off-by: Justin Yu <justinvyu@anyscale.com>
Signed-off-by: Justin Yu <justinvyu@anyscale.com>
Signed-off-by: Justin Yu <justinvyu@anyscale.com>
lightgbm_ray/tune.py Outdated Show resolved Hide resolved
Signed-off-by: Justin Yu <justinvyu@anyscale.com>
@justinvyu justinvyu merged commit 4c4d341 into main Feb 4, 2024
26 checks passed
@justinvyu justinvyu deleted the fix_lgbm_ckpting branch February 4, 2024 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants