Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add format script #31

Merged
merged 6 commits into from
Mar 4, 2022
Merged

Add format script #31

merged 6 commits into from
Mar 4, 2022

Conversation

BalaBalaYi
Copy link
Collaborator

Add a 'format.sh' to format shell, c++, python, java files.

@BalaBalaYi BalaBalaYi requested a review from ashione March 3, 2022 02:07
@ashione
Copy link
Member

ashione commented Mar 3, 2022

Thanks for contributing CI/CD format tools. It would be better to add tutorial for other devs or contributors.

@ashione
Copy link
Member

ashione commented Mar 3, 2022

I has one suggestion about code lint.
How to execute format.sh and show diff in git diff > diff.txt, and check whether diff.txt is empty.
Non-empty diff content means changes have no lint problems.

Any thoughts about that? @jovany-wang

@jovany-wang
Copy link
Contributor

@ashione ashione merged commit e210963 into master Mar 4, 2022
@jovany-wang jovany-wang deleted the add_format_script branch March 4, 2022 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants