resolve comments

ray-project · Jul 9, 2019 · 78bfc24 · 78bfc24
1 parent 3514156
commit 78bfc24
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 0 deletions.
diff --git a/src/ray/raylet/node_manager.cc b/src/ray/raylet/node_manager.cc
@@ -763,9 +763,11 @@ void NodeManager::ProcessClientMessage(
     ProcessRegisterClientRequestMessage(client, message_data);
   } break;
   case protocol::MessageType::GetTask: {
+    RAY_CHECK(!registered_worker->UsePush());
     ProcessGetTaskMessage(client);
   } break;
   case protocol::MessageType::TaskDone: {
+    RAY_CHECK(registered_worker->UsePush());
     ProcessGetTaskMessage(client);
   } break;
   case protocol::MessageType::DisconnectClient: {

diff --git a/src/ray/raylet/scheduling_resources.h b/src/ray/raylet/scheduling_resources.h
@@ -446,6 +446,7 @@ class ResourceIdSet {
   /// \brief Serialize this object as a string.
   ///
   /// \return A serialized string of this object.
+  /// TODO(zhijunfu): this can be removed after raylet client is migrated to grpc.
   const std::string Serialize() const;
 
  private: