Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[doc] Provide source links to documentation #3269

Closed
richardliaw opened this issue Nov 7, 2018 · 6 comments
Closed

[doc] Provide source links to documentation #3269

richardliaw opened this issue Nov 7, 2018 · 6 comments
Labels
good first issue Great starter issue for someone just starting to contribute to Ray

Comments

@richardliaw
Copy link
Contributor

All Keras methods have a "source" link (as does/did? Numpy).

It would be good to add this to Ray documentation.

Example: https://keras.io/layers/merge/

@richardliaw richardliaw added help wanted good first issue Great starter issue for someone just starting to contribute to Ray labels Nov 7, 2018
@tashachin
Copy link
Contributor

Hi, I'd like to help with this issue.

Where would I be fetching and inserting hyperlinks? I'm not 100% sure I understand the endpoint architecture or the needs of your project.

@richardliaw
Copy link
Contributor Author

richardliaw commented Nov 8, 2018

Thanks for offering @tashachin! I just took a quick look into actually doing this, and it might not be too hard to do.

Ideally, we'd have for all of these methods on this page (https://ray.readthedocs.io/en/latest/tune-package-ref.html), a link to [source] that looks like
test

From this thread, readthedocs/readthedocs.org#2139 (comment), it seems like you can just modify a configuration script parameter so that this is the case?

Let me know if you plan to take a look into this/if you have any more questions.

@tashachin
Copy link
Contributor

Hey @richardliaw I have a potential solve but I'm not sure how to run tests on my local machine.

I noticed that in your conf.py, line 220 is commented out:

# If true, links to the reST sources are added to the pages.
#html_show_sourcelink = True

Is this intentional by design? I forked the repo and am ready to submit a PR to switch this flag, but I'm concerned it'd affect your project on a much wider scale than is necessary.

@richardliaw
Copy link
Contributor Author

richardliaw commented Nov 8, 2018

Hey @tashachin; you can just run make html and if it doesn't throw any warnings, you'll probably have passed the test.

I think that line is not intentional; switching it might be fine.

Feel free to post the PR! I'll work with you to fix things and get it merged.

@tashachin
Copy link
Contributor

Hey @richardliaw; I won't have access to my Macbook for a month or so. I'd like to let someone else handle this issue in my stead.

Thanks for your patience and for letting me attempt this one.

@richardliaw
Copy link
Contributor Author

This is addressed in #3281.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Great starter issue for someone just starting to contribute to Ray
Projects
None yet
Development

No branches or pull requests

3 participants