Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core: Importing ray causes critical log messages to not be shown #37941

Closed
klieret opened this issue Jul 31, 2023 · 4 comments
Closed

Core: Importing ray causes critical log messages to not be shown #37941

klieret opened this issue Jul 31, 2023 · 4 comments
Labels
bug Something that is supposed to be working; but isn't core Issues that should be addressed in Ray Core triage Needs triage (eg: priority, bug/not-bug, and owning component)

Comments

@klieret
Copy link
Contributor

klieret commented Jul 31, 2023

What happened + What you expected to happen

Simply importing ray hides all log messages in the newest ray version when importing a logger.
This is a new issue with ray 2.6.xx (I can confirm that this issue does not appear with 2.5.1).

This sounds somewhat similar to #17374, but here ray isn't even initialized (and the solution presented there does not work).

Versions / Dependencies

  • ray 2.6.1 (not an issue with 2.5.1)
  • py 3.11.3

Reproduction script

Create file log.py:

import logging

logger = logging.getLogger("test")

Create file test_log.py:

from log import logger
# import ray

logger.critical("This is bad")

Executing test_log.py like this causes the log message to be shown (as expected).
However, uncommenting import ray, no more log message is shown.

Issue Severity

High: It blocks me from completing my task.

@klieret klieret added bug Something that is supposed to be working; but isn't triage Needs triage (eg: priority, bug/not-bug, and owning component) labels Jul 31, 2023
@richardliaw
Copy link
Contributor

This seems similar to #37920.

@jjyao jjyao added the core Issues that should be addressed in Ray Core label Jul 31, 2023
@jjyao
Copy link
Contributor

jjyao commented Jul 31, 2023

This should be a duplicate of #37941. This has been fixed in master and will be released in 2.6.2 soon.

@klieret
Copy link
Contributor Author

klieret commented Jul 31, 2023

Thanks @richardliaw @jjyao . Accidentally had an is:open filter in my issue search, I realized. Sorry for the duplicate!

@xieus
Copy link

xieus commented Aug 4, 2023

@klieret Ray 2.6.2 is released today with an proper fix.
https://github.com/ray-project/ray/releases/tag/ray-2.6.2

Please check it out and let us know how it goes. Thank you for your patience and understanding.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something that is supposed to be working; but isn't core Issues that should be addressed in Ray Core triage Needs triage (eg: priority, bug/not-bug, and owning component)
Projects
None yet
Development

No branches or pull requests

4 participants