Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[data] Capture Data-internal exceptions #40802

Closed
stephanie-wang opened this issue Oct 30, 2023 · 3 comments · Fixed by #43735
Closed

[data] Capture Data-internal exceptions #40802

stephanie-wang opened this issue Oct 30, 2023 · 3 comments · Fixed by #43735
Assignees
@scottjlee
Labels
data Ray Data-related issues enhancement Request for new feature and/or capability P1 Issue that should be fixed within a few weeks ray 2.10 release-blocker P0 Issue that blocks the release

Comments

@stephanie-wang
Copy link
Contributor

Description

Currently Data throws all exceptions to the user, both from user-defined code and Data-internal code. Errors are not differentiated, which makes it difficult to understand the error output.

Ideally, we should capture exceptions from user-defined code, throw these as a separate type of error, and match the stacktrace to the original user code. Also, we should improve the error message for Data-internal errors to direct the user to file a GitHub issue.

Use case

No response
@stephanie-wang stephanie-wang added enhancement Request for new feature and/or capability triage Needs triage (eg: priority, bug/not-bug, and owning component) labels Oct 30, 2023
@anyscalesam anyscalesam added data Ray Data-related issues ray 2.10 labels Nov 1, 2023
@bveeramani bveeramani added P2 Important issue, but not time-critical and removed triage Needs triage (eg: priority, bug/not-bug, and owning component) labels Nov 7, 2023
@anyscalesam anyscalesam added P1 Issue that should be fixed within a few weeks and removed P2 Important issue, but not time-critical labels Dec 8, 2023
@anyscalesam
Copy link
Collaborator

discussed with @c21 this can map to the error improvement project @Zandew is looking at. upping to p1 cause this would make it sooo much easier to debug issues with ray data.

@c21 c21 unassigned Zandew Dec 11, 2023
@Zandew Zandew self-assigned this Dec 11, 2023
@scottjlee scottjlee assigned scottjlee and unassigned Zandew Jan 9, 2024
@scottjlee
Copy link
Contributor

Closed by #43251

@c21
Copy link
Contributor

c21 commented Mar 6, 2024

The original PR is reverted. Reopening.

@c21 c21 reopened this Mar 6, 2024
@c21 c21 added the release-blocker P0 Issue that blocks the release label Mar 6, 2024
@scottjlee scottjlee mentioned this issue Mar 6, 2024
Merged
raulchen pushed a commit that referenced this issue Mar 6, 2024
@scottjlee
Revert "Revert "[Data] Reduce internal Ray Data stack trace output by…
fbcc511 
… default"" (#43735)

Reverts #43638, adding changes from original PR #43251 with fix for breaking osx / windows tests.

Closes #40802

Postmerge test run: https://buildkite.com/ray-project/postmerge/builds/3306

---------

Signed-off-by: Scott Lee <sjl@anyscale.com>
@jamienoss jamienoss mentioned this issue Apr 4, 2024
Merged
ryanaoleary pushed a commit to ryanaoleary/ray that referenced this issue Jun 7, 2024
@scottjlee @ryanaoleary
Revert "Revert "[Data] Reduce internal Ray Data stack trace output by…
6cd0be0 
… default"" (ray-project#43735)

Reverts ray-project#43638, adding changes from original PR ray-project#43251 with fix for breaking osx / windows tests.

Closes ray-project#40802

Postmerge test run: https://buildkite.com/ray-project/postmerge/builds/3306

---------

Signed-off-by: Scott Lee <sjl@anyscale.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@scottjlee scottjlee

Labels
data Ray Data-related issues enhancement Request for new feature and/or capability P1 Issue that should be fixed within a few weeks ray 2.10 release-blocker P0 Issue that blocks the release
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Revert "Revert "[Data] Reduce internal Ray Data stack trace output by default"" ray-project/ray
6 participants
@stephanie-wang @c21 @scottjlee @bveeramani @Zandew @anyscalesam