Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tune] [serve] Don't use daemon threads #6421

Open
edoakes opened this issue Dec 10, 2019 · 1 comment
Open

[tune] [serve] Don't use daemon threads #6421

edoakes opened this issue Dec 10, 2019 · 1 comment
Labels
enhancement Request for new feature and/or capability good first issue Great starter issue for someone just starting to contribute to Ray P3 Issue moderate in impact or severity tune Tune-related issues

Comments

@edoakes
Copy link
Contributor

edoakes commented Dec 10, 2019

Describe your feature request

Use normal threads and join them on shutdown instead of using daemon threads and letting the OS terminate them to ensure everything is cleaned up properly on exit.

cc @richardliaw @simon-mo

@edoakes edoakes added the enhancement Request for new feature and/or capability label Dec 10, 2019
@richardliaw richardliaw added the tune Tune-related issues label Mar 5, 2020
@stale
Copy link

stale bot commented Nov 13, 2020

Hi, I'm a bot from the Ray team :)

To help human contributors to focus on more relevant issues, I will automatically add the stale label to issues that have had no activity for more than 4 months.

If there is no further activity in the 14 days, the issue will be closed!

  • If you'd like to keep the issue open, just leave any comment, and the stale label will be removed!
  • If you'd like to get more attention to the issue, please tag one of Ray's contributors.

You can always ask for help on our discussion forum or Ray's public slack channel.

@stale stale bot added the stale The issue is stale. It will be closed within 7 days unless there are further conversation label Nov 13, 2020
@richardliaw richardliaw added good first issue Great starter issue for someone just starting to contribute to Ray P3 Issue moderate in impact or severity labels Nov 13, 2020
@stale stale bot removed the stale The issue is stale. It will be closed within 7 days unless there are further conversation label Nov 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Request for new feature and/or capability good first issue Great starter issue for someone just starting to contribute to Ray P3 Issue moderate in impact or severity tune Tune-related issues
Projects
None yet
Development

No branches or pull requests

2 participants