Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Needs flags to enable/disable printing colored log messages #6855

Closed
JasonWayne opened this issue Jan 20, 2020 · 5 comments · Fixed by #45218
Closed

Needs flags to enable/disable printing colored log messages #6855

JasonWayne opened this issue Jan 20, 2020 · 5 comments · Fixed by #45218
Labels
core Issues that should be addressed in Ray Core dashboard Issues specific to the Ray Dashboard enhancement Request for new feature and/or capability good first issue Great starter issue for someone just starting to contribute to Ray observability Issues related to the Ray Dashboard, Logging, Metrics, Tracing, and/or Profiling P1 Issue that should be fixed within a few weeks

Comments

@JasonWayne
Copy link
Contributor

Ray will print colored log in console which is a very nice feature. However, some consoles do not support interpret the color info, so it becomes some ugly looking log messages. I think ray needs some flags to disable this colored print in such scenario.

ref: https://groups.google.com/forum/#!topic/ray-dev/SpGaKhXbWAY

@JasonWayne JasonWayne added the enhancement Request for new feature and/or capability label Jan 20, 2020
@JasonWayne
Copy link
Contributor Author

@richardliaw Pls help to check, thks.

@ericl ericl added the P3 Issue moderate in impact or severity label Mar 19, 2020
@rkooo567 rkooo567 added P1 Issue that should be fixed within a few weeks dashboard Issues specific to the Ray Dashboard observability Issues related to the Ray Dashboard, Logging, Metrics, Tracing, and/or Profiling and removed P3 Issue moderate in impact or severity labels Nov 16, 2022
@rkooo567
Copy link
Contributor

This feature is requested by Dan (@kiralaz)

@kiralaz
Copy link

kiralaz commented Nov 16, 2022

Thanks @rkooo567, it would be nice to be able to disable colored logging (perhaps via an environment variable?) as in our cloud jobs with ray we get some pretty ugly logs with prefixes like this [2m[36m(ActorName, pid=<pid>.... instead of just (ActorName, pid=...

@klazuka
Copy link

klazuka commented Nov 21, 2022

I would also like to be able to disable the colored output as well as disable the custom log formatting in general.

We use Datadog for all of our cloud-based logs, and our applications emit JSON log messages direct to stdout. We would like the Datadog agent running in the EKS cluster to be able to obtain the original JSON messages, without any additional formatting by Ray.

@rkooo567 rkooo567 added Ray 2.4 and removed Ray 2.3 labels Feb 20, 2023
@npuichigo
Copy link
Contributor

@rkooo567 kindly ask is there any update?

@jjyao jjyao added core Issues that should be addressed in Ray Core good first issue Great starter issue for someone just starting to contribute to Ray and removed Ray 2.4 labels Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Issues that should be addressed in Ray Core dashboard Issues specific to the Ray Dashboard enhancement Request for new feature and/or capability good first issue Great starter issue for someone just starting to contribute to Ray observability Issues related to the Ray Dashboard, Logging, Metrics, Tracing, and/or Profiling P1 Issue that should be fixed within a few weeks
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants