Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tune] change trial dir default to include name #10608

Merged
merged 1 commit into from Sep 8, 2020

Conversation

richardliaw
Copy link
Contributor

Why are these changes needed?

Make the default trial dir also include the trial name.

Related issue number

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/latest/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failure rates at https://ray-travis-tracker.herokuapp.com/.
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested (please justify below)

@janblumenkamp
Copy link
Contributor

Thanks, Richard! Is the date_str() necessary because there are no guarantees that the trial id is unique?
Maybe it would make sense to somehow unify this across all loggers (I am particularly thinking about the wandb logger, maybe there are others that are affected by this). For example, in the wandb logger, only the string representation of a trial is shown as name. It would be good if the name shown in the wandb logger would be exactly the same as the name of the directory that contains the checkpoints (so str(trial)+date_str() or something like that).

@richardliaw
Copy link
Contributor Author

Hmm @janblumenkamp - unfortunately the tensorboard visualization sort of requires us to append a nasty string to the end of the directory name. We could perhaps get rid of the timestring if you think that's too verbose. We have it there for convenience (i.e., to see which trials were created when).

@richardliaw richardliaw marked this pull request as ready for review September 7, 2020 22:32
@richardliaw richardliaw changed the title [tune] fix trial dir default [tune] change trial dir default to include name Sep 8, 2020
@richardliaw richardliaw merged commit 41bf5f3 into ray-project:master Sep 8, 2020
@richardliaw richardliaw deleted the dir-path-trial branch September 8, 2020 02:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants