Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rllib] Remove broken no eager on workers mode #10745

Merged
merged 2 commits into from
Sep 16, 2020

Conversation

ericl
Copy link
Contributor

@ericl ericl commented Sep 11, 2020

Why are these changes needed?

This option was not tested and is currently broken (and not easy to fix); remove it

@ericl
Copy link
Contributor Author

ericl commented Sep 13, 2020

Ping @sven1977

Copy link
Contributor

@sven1977 sven1977 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sven1977
Copy link
Contributor

test_env_with_sub_process.py fails again. A ray core problem?

@ericl ericl merged commit f83c588 into ray-project:master Sep 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants