[tune] lazy trials #10802
Merged
[tune] lazy trials #10802
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Open question: Should we remove the |
richardliaw
reviewed
Sep 15, 2020
Comment on lines
83
to
87
| def next_trials(self): | ||
| """Provides Trial objects to be queued into the TrialRunner. | ||
|
|
||
| Returns: | ||
| trials (list): Returns a list of trials. | ||
| List[Trial]: A list of trials for the Runner to consume. |
added 3 commits
September 16, 2020 09:47
# Conflicts: # python/ray/tune/suggest/basic_variant.py # python/ray/tune/suggest/search.py # python/ray/tune/suggest/search_generator.py
richardliaw
reviewed
Sep 16, 2020
richardliaw
reviewed
Sep 16, 2020
…llow infinite samples.
|
I added the total number of samples to the printout. Also implemented (virtually) infinite samples when |
richardliaw
approved these changes
Sep 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Create Trial objects one by one from search algorithms. This way the scheduled trials get naturally limited by concurrency limits of the searcher (through
ConcurrencyLimiter) and theTrialRunner(through resources).Related issue number
#10138
Checks
scripts/format.shto lint the changes in this PR.