[RLlib] Trajectory view API: Simple List Collector (on by default for PPO); LSTM-agnostic #11056
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sven1977
commented
Sep 27, 2020
rllib/agents/a3c/a3c.py
Outdated
| @@ -59,6 +59,14 @@ def validate_config(config): | |||
| logger.warning("`sample_async=True` is not supported for PyTorch! " | |||
| "Multithreading can lead to crashes.") | |||
|
|
|||
| # Switch on trajectory view API by default for this algo (if None). | |||
There was a problem hiding this comment.
Switch on by default for A2/3C.
There was a problem hiding this comment.
Please set this in the A2C config instead of in the code.
sven1977
commented
Sep 27, 2020
rllib/agents/pg/pg.py
Outdated
| @@ -33,6 +36,24 @@ | |||
| # yapf: enable | |||
|
|
|||
|
|
|||
| def validate_config(config: TrainerConfigDict) -> None: | |||
There was a problem hiding this comment.
Switch on by default for PG.
There was a problem hiding this comment.
Please set this in the algorithm config instead of in the code, here and elsewhere.
ericl
approved these changes
Sep 28, 2020
ericl
added
the
@author-action-required
|
LGTM, let's get it merged! |
ericl
reviewed
Sep 28, 2020
rllib/agents/ppo/ppo.py
Outdated
| @@ -89,6 +89,9 @@ | |||
| # Whether to fake GPUs (using CPUs). | |||
| # Set this to True for debugging on non-GPU machines (set `num_gpus` > 0). | |||
| "_fake_gpus": False, | |||
| # Switch on Trajectory View API for A2/3C by default. | |||
ericl
reviewed
Sep 28, 2020
rllib/agents/pg/pg.py
Outdated
| @@ -27,6 +30,9 @@ | |||
| "num_workers": 0, | |||
| # Learning rate. | |||
| "lr": 0.0004, | |||
| # Switch on Trajectory View API for A2/3C by default. | |||
|
Fixing last failing tests. ... |
…ectory_view_api_simple_collector
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trajectory view API:
This finishes the following part of the Traj. View milestone:
Issue #10879
Closes Issue #10879
Checks
scripts/format.shto lint the changes in this PR.