Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RLlib] SAC: log_alpha not being learnt when on GPU. #11298

Merged
merged 3 commits into from
Oct 12, 2020
Merged

[RLlib] SAC: log_alpha not being learnt when on GPU. #11298

merged 3 commits into from
Oct 12, 2020

Conversation

sven1977
Copy link
Contributor

@sven1977 sven1977 commented Oct 9, 2020 •
edited
Loading

When SAC is run on a GPU in PyTorch, the log_alpha parameter is not learnt (due to it being located on the CPU).
Closes issue: #11294

Closes #11294

Closes #11294

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@sven1977 sven1977 requested a review from ericl October 9, 2020 06:41
@sven1977 sven1977 mentioned this pull request Oct 9, 2020
Closed
2 tasks
@sven1977 sven1977 added the tests-ok The tagger certifies test failures are unrelated and assumes personal liability. label Oct 11, 2020
@ericl ericl merged commit f5e2cda into ray-project:master Oct 12, 2020
@sven1977 sven1977 deleted the issue_11294_sac_not_learning_alpha_on_gpu branch January 18, 2021 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericl ericl ericl approved these changes

Assignees

@ericl ericl

Labels
tests-ok The tagger certifies test failures are unrelated and assumes personal liability.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[rllib] SAC (pytorch) log_alpha not optimizing with GPU enabled
2 participants
@sven1977 @ericl