[RLlib] Do not create env on driver iff num_workers > 0. #11307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e_11302_no_env_on_driver_when_num_workers_larger_0
…e_11302_no_env_on_driver_when_num_workers_larger_0
…e_11302_no_env_on_driver_when_num_workers_larger_0
michaelzhiluo
approved these changes
Oct 14, 2020
rllib/evaluation/rollout_worker.py
Outdated
| from gym import wrappers | ||
| env = wrappers.Monitor(env, monitor_path, resume=True) | ||
| return env | ||
| if worker_index == 0 and num_workers > 0: |
There was a problem hiding this comment.
Possible conflict with MBMPO since local worker samples from real evn with multilple workers.
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not create an Env object on the driver in case num_workers > 0.
#11302
Addresses #11302
Closes #11302
Checks
scripts/format.shto lint the changes in this PR.