Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RLlib] Implement the SlateQ algorithm #11450

Merged
merged 20 commits into from
Nov 3, 2020
Merged

[RLlib] Implement the SlateQ algorithm #11450

merged 20 commits into from
Nov 3, 2020

Conversation

desktable
Copy link
Contributor

Why are these changes needed?

Implemented the SlateQ algorithm.

Related issue number

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@desktable desktable changed the title [WIP] Implement the SlateQ algorithm [RLlib] Implement the SlateQ algorithm [WIP] Oct 17, 2020
@desktable desktable force-pushed the slateq branch 2 times, most recently from 5829a85 to 34d8596 Compare October 25, 2020 22:32
@sven1977 sven1977 self-assigned this Oct 29, 2020
@sven1977 sven1977 self-requested a review October 29, 2020 17:14
@desktable desktable changed the title [RLlib] Implement the SlateQ algorithm [WIP] [RLlib] Implement the SlateQ algorithm Nov 1, 2020
sven1977
sven1977 approved these changes Nov 2, 2020
View reviewed changes
Copy link
Contributor

@sven1977 sven1977 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work! Thanks. Just some minor comments and fixes to be done before merging.

rllib/agents/slateq/slateq.py Show resolved Hide resolved
rllib/agents/slateq/slateq.py Show resolved Hide resolved
rllib/examples/slateq.py Show resolved Hide resolved
rllib/agents/slateq/slateq_torch_policy.py Outdated Show resolved Hide resolved
@sven1977 sven1977 merged commit 5af745c into ray-project:master Nov 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sven1977 sven1977 sven1977 approved these changes

Assignees

@sven1977 sven1977

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@desktable @sven1977