[autoscaler] SDK fixes #11517
Merged
[autoscaler] SDK fixes #11517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richardliaw
reviewed
Oct 21, 2020
| def teardown_cluster(cluster_config: Union[dict, str]) -> None: | ||
| def teardown_cluster(cluster_config: Union[dict, str], | ||
| workers_only: bool = False, | ||
| keep_min_workers: bool = False) -> None: | ||
| """Destroys all nodes of a Ray cluster described by a config json. | ||
|
|
||
| Args: |
There was a problem hiding this comment.
don't forget docstrings
richardliaw
previously requested changes
Oct 21, 2020
richardliaw
approved these changes
Oct 22, 2020
|
let me know if you need help merging after tests pass |
ericl
requested changes
Oct 22, 2020
|
Sounds good, I think *the need for this* is actually going away (for the
exact reasons mentioned).
…On Thu, Oct 22, 2020 at 12:16 PM Eric Liang ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In python/ray/autoscaler/sdk.py
<#11517 (comment)>:
> @@ -102,7 +108,8 @@ def rsync(cluster_config: Union[dict, str],
down: bool,
ip_address: str = None,
use_internal_ip: bool = False,
- no_config_cache: bool = False):
+ no_config_cache: bool = False,
+ all_nodes: bool = False):
It's exposed there, but only as a best effort kind of thing for clusters
that are up. I want to discourage users from using that option however
(maybe we should even remove it).
It's not a reliable building block given that clusters are inherently
autoscaling.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#11517 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AFC5KQS2QOGALZE5ZKV6YNLSMCAH7ANCNFSM4SZJOLRQ>
.
|
ericl
approved these changes
Oct 22, 2020
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Expose more of the API in the autoscaler SDK.
Related issue number
Checks
scripts/format.shto lint the changes in this PR.