[autoscaler] Clean up monitoring loop code

[ericl]

Why are these changes needed?

• Rename get_all_heartbeats to update_load_metrics
• Remove unused job pubsub handler
• Fix up the loop structure

[wuisawesome]

Looks pretty innocuous so long as the dead code really is dead.

[WangTaoTheTonic]

test_multi_mode_2.py uses monitor and it still subscribes XRAY_JOB_PATTERN, which should be removed.

[WangTaoTheTonic]

And also get_all_heartbeat is used in other places, which should be renamed.

[WangTaoTheTonic]

Suggested change

monitor.subscribe(ray.ray_constants.AUTOSCALER_RESOURCE_REQUEST_CHANNEL)

We can simply remove this as no autoscaler related message should be handled in this test case.

[ericl]

Ah, the reason I kept that was since an error is raised if there is no subscriptions at all.

…

On Thu, Oct 29, 2020, 12:51 AM Tao Wang ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In python/ray/tests/test_multi_node_2.py <#11677 (comment)>: > @@ -68,13 +68,13 @@ def setup_monitor(address): monitor = Monitor( address, None, redis_password=ray_constants.REDIS_DEFAULT_PASSWORD) monitor.update_raylet_map(_append_port=True) - monitor.psubscribe(ray.gcs_utils.XRAY_JOB_PATTERN) # TODO: Remove? + monitor.subscribe(ray.ray_constants.AUTOSCALER_RESOURCE_REQUEST_CHANNEL) ⬇️ Suggested change - monitor.subscribe(ray.ray_constants.AUTOSCALER_RESOURCE_REQUEST_CHANNEL) + monitor.subscribe(ray.ray_constants.AUTOSCALER_RESOURCE_REQUEST_CHANNEL) We can simply remove this as no autoscaler related message should be handled in this test case. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#11677 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAADUSW6TG4YUZ42ENYUXODSNENIVANCNFSM4TCZRZZA> .

[WangTaoTheTonic]

LGTM :)