[autoscaler] fix the autoscaling bug for continuously launching failed nodes #11714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 818a63a.
… consider only load_metric's connected nodes as running
ericl
approved these changes
Oct 30, 2020
ericl
added
the
tests-ok
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we considered pending and running nodes based on node tags rather than connected nodes from load metrics. This might be problematic as we cannot rely on node tags. This PR defines running nodes as connected nodes from LoadMetrics and pending nodes as the remaining nodes (non_terminated_nodes-connected nodes + pending queue) Furthermore, this PR treats the nodes that failed to launch as pending, and hence the number of failed nodes that are launched will be bounded by the max allowed pending nodes (in the code the handles the max concurrency).
Unblocks #11615 (merge after merging this please).
Related issue number
Checks
scripts/format.shto lint the changes in this PR.