[Serve] add dependency management #11743
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: SangBin Cho <rkooo567@gmail.com>
Co-authored-by: SangBin Cho <rkooo567@gmail.com>
…into override-worker-env
Co-authored-by: Edward Oakes <ed.nmi.oakes@gmail.com>
…into serve-dep-mgmt
|
@architkulkarni looks like some of the CI jobs failed mysteriously. Restarting, should be good to merge after that. |
architkulkarni
added
the
tests-ok
simon-mo
reviewed
Nov 5, 2020
python/ray/serve/api.py
Outdated
| from ray.actor import ActorHandle | ||
| from typing import Any, Callable, Dict, List, Optional, Type, Union | ||
| import os |
There was a problem hiding this comment.
can you move the import to line 4? stdlib should be groupped together, see https://google.github.io/styleguide/pyguide.html#313-imports-formatting
There was a problem hiding this comment.
Sure thing, thanks for the reference!
python/ray/serve/tests/test_util.py
Outdated
| @@ -1,12 +1,13 @@ | |||
| import asyncio | |||
| import json | |||
| from copy import deepcopy | |||
|
|
|||
| import os | |||
There was a problem hiding this comment.
move this import to first group stdlib
simon-mo
added
@author-action-required
Co-authored-by: Simon Mo <simon.mo@hey.com>
architkulkarni
added
tests-ok
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Uses environment variable overrides for actors (#11619) to allow simultaneously serving backends with conflicting dependencies, using
condaenvironments. The environments must be preinstalled on all nodes.Usage example:
Related issue number
Comments on an earlier version of this PR can be found at architkulkarni#1.
Checks
scripts/format.shto lint the changes in this PR.