[tune] logger refactor part 3: Add ExperimentLogger class #11749
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
November 2, 2020 11:06
7 tasks
added 7 commits
November 2, 2020 20:26
# Conflicts: # python/ray/tune/logger.py
# Conflicts: # python/ray/tune/logger.py # python/ray/tune/utils/callback.py
# Conflicts: # python/ray/tune/callback.py # python/ray/tune/logger.py # python/ray/tune/tests/test_cluster.py
|
(needs a quick rebase?) |
richardliaw
added
the
@author-action-required
added 3 commits
November 4, 2020 10:08
…er-3 # Conflicts: # python/ray/tune/logger.py # python/ray/tune/syncer.py # python/ray/tune/trial.py # python/ray/tune/tune.py # python/ray/tune/utils/callback.py
krfricke
removed
the
@author-action-required
richardliaw
reviewed
Nov 4, 2020
richardliaw
reviewed
Nov 4, 2020
richardliaw
reviewed
Nov 4, 2020
richardliaw
reviewed
Nov 4, 2020
| # Todo(krfricke): Deprecate `loggers` argument, print warning here. | ||
| add_loggers = [] | ||
| for trial_logger in loggers: | ||
| if isinstance(trial_logger, ExperimentLogger): |
There was a problem hiding this comment.
When will users pass an ExperimentLogger via loggers?
There was a problem hiding this comment.
They shouldn', but they might, so I guess we should handle this. We could also raise an error here instead
richardliaw
reviewed
Nov 4, 2020
| has_csv_logger = True | ||
| if JsonLogger in callback.logger_classes: | ||
| has_json_logger = True | ||
| # Todo(krfricke): add checks for new ExperimentLogger classes |
There was a problem hiding this comment.
will this todo be part of this PR?
There was a problem hiding this comment.
No, this will be a follow up once we implemented a "native" CSV/JSON ExperimentLogger
richardliaw
reviewed
Nov 4, 2020
Comment on lines
+83
to
+93
| if syncer_index is not None and last_logger_index is not None and \ | ||
| syncer_index < last_logger_index: | ||
| if (not has_csv_logger or not has_json_logger) and not loggers: | ||
| # Only raise the warning if the loggers were passed by the user. | ||
| # (I.e. don't warn if this was automatic behavior and they only | ||
| # passed a customer SyncerCallback). | ||
| raise ValueError( | ||
| "The `SyncerCallback` you passed to `tune.run()` came before " | ||
| "at least one `ExperimentLogger`. Syncing should be done " | ||
| "after writing logs. Please re-order the callbacks so that " | ||
| "the `SyncerCallback` comes after any `ExperimentLogger`.") |
There was a problem hiding this comment.
hmm, can we just make sure the syncer is last?
There was a problem hiding this comment.
That's what we do here, right? If someone passes callbacks=[syncer, logger] it will raise an error. If someone passes callbacks=[syncer] and the logger is created automatically, it will just put the syncer last and everything will work.
richardliaw
approved these changes
Nov 5, 2020
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Second split of PR ##11699, builds on #11748
Checks
scripts/format.shto lint the changes in this PR.