Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SGD] Better support for custom DDP #11771

Merged
merged 7 commits into from
Nov 4, 2020
Merged

[SGD] Better support for custom DDP #11771

merged 7 commits into from
Nov 4, 2020

Conversation

amogkam
Copy link
Contributor

@amogkam amogkam commented Nov 2, 2020 •
edited

Why are these changes needed?

  • Add ddp_args field to register and move apex_args to register as well
  • Update documentation

Related issue number

Closes #11705, #10096

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@richardliaw
Copy link
Contributor

@krfricke could you take a look? thanks!

richardliaw
richardliaw approved these changes Nov 3, 2020
View reviewed changes
Copy link
Contributor

@richardliaw richardliaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great! left a couple nits

@richardliaw
Copy link
Contributor

Hmm, sgd test is failing

@richardliaw richardliaw added the @author-action-required The PR author is responsible for the next step. Remove tag to send back to the reviewer. label Nov 4, 2020
@amogkam
Copy link
Contributor Author

amogkam commented Nov 4, 2020

@richardliaw fixed now- tests are passing.

@amogkam amogkam added tests-ok The tagger certifies test failures are unrelated and assumes personal liability. and removed @author-action-required The PR author is responsible for the next step. Remove tag to send back to the reviewer. labels Nov 4, 2020
@richardliaw richardliaw merged commit 92718de into ray-project:master Nov 4, 2020
@amogkam amogkam mentioned this pull request Nov 4, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardliaw richardliaw richardliaw approved these changes

Assignees

@richardliaw richardliaw

Labels
tests-ok The tagger certifies test failures are unrelated and assumes personal liability.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[SGD] Better support for custom DDP
2 participants
@amogkam @richardliaw