Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tune] refactor and add examples #11931

Merged
merged 13 commits into from
Nov 15, 2020
Merged

[tune] refactor and add examples #11931

merged 13 commits into from
Nov 15, 2020

Conversation

richardliaw
Copy link
Contributor

Why are these changes needed?

Make sure examples show a complete workflow and add missing examples to page.

Related issue number

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@richardliaw
add-examples
260c9bb 
Signed-off-by: Richard Liaw <rliaw@berkeley.edu>
@richardliaw
fix
72f325a 
Signed-off-by: Richard Liaw <rliaw@berkeley.edu>
@richardliaw
fix-index
2773a36 
Signed-off-by: Richard Liaw <rliaw@berkeley.edu>
@richardliaw
fix-scripts
6068ddb 
Signed-off-by: Richard Liaw <rliaw@berkeley.edu>
@richardliaw
fix
00cc95a 
Signed-off-by: Richard Liaw <rliaw@berkeley.edu>
amogkam
amogkam approved these changes Nov 13, 2020
View reviewed changes
Copy link
Contributor

@amogkam amogkam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

krfricke
krfricke previously requested changes Nov 13, 2020
View reviewed changes
Copy link
Contributor

@krfricke krfricke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's get rid of the **tune_kwargs in a handful of these examples. Otherwise great and much needed!

python/ray/tune/examples/ax_example.py Show resolved Hide resolved
python/ray/tune/examples/cifar10_pytorch.py Show resolved Hide resolved
python/ray/tune/examples/skopt_example.py Outdated Show resolved Hide resolved
@richardliaw
fix
664cd8f 
Signed-off-by: Richard Liaw <rliaw@berkeley.edu>
@richardliaw
fix
ab2f671 
Signed-off-by: Richard Liaw <rliaw@berkeley.edu>
@richardliaw
fix-examples
b55b925 
Signed-off-by: Richard Liaw <rliaw@berkeley.edu>
@richardliaw
fix-example
7f92842 
Signed-off-by: Richard Liaw <rliaw@berkeley.edu>
@richardliaw
fix-exp
505aa26 
Signed-off-by: Richard Liaw <rliaw@berkeley.edu>
@richardliaw
fix
597c004 
Signed-off-by: Richard Liaw <rliaw@berkeley.edu>
@richardliaw
fix
4efb424 
Signed-off-by: Richard Liaw <rliaw@berkeley.edu>
@richardliaw
Merge branch 'master' into fix-up-example
6a2d41d
@richardliaw richardliaw merged commit 8b3f79f into ray-project:master Nov 15, 2020
@richardliaw richardliaw deleted the fix-up-example branch November 15, 2020 04:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krfricke krfricke krfricke left review comments

@amogkam amogkam amogkam approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@richardliaw @amogkam @krfricke