-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[tune] Fix hpo randint limits #11946
[tune] Fix hpo randint limits #11946
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks perfect, assuming tests pass—thanks @krfricke
@krfricke the CI errors made me realize—this is a breaking change, right? This should be a pretty easy fix for tune users but if we really want to stick to semver maybe we should change |
Is it a breaking change? As I see it it just affects the search space conversion, and Tune's |
But I guess we could pass kwargs to hyperopt. instead of args to be sure. Can you update the PR? |
I think this is backwards compatible, so it's safe to include without modifications to signature. |
tests failing though |
Ahh yup that's my bad; I forgot we had our own
sure, is c142b85 what you were expecting? edit: whoops, just saw this:
happy to revert part of the kwarg commit to stick to args for the signature |
Why are these changes needed?
HyperOpt actually supports broader limits for randint.
Related issue number
Checks
scripts/format.sh
to lint the changes in this PR.