Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docker] auto-populate shared memory size #11953

Merged
merged 6 commits into from
Nov 13, 2020
Merged

[docker] auto-populate shared memory size #11953

merged 6 commits into from
Nov 13, 2020

Conversation

ijrsvt
Copy link
Contributor

@ijrsvt ijrsvt commented Nov 11, 2020 •
edited

Why are these changes needed?

  • Set --shm-size when Docker is in use.

Related issue number

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@ericl
Copy link
Contributor

ericl commented Nov 11, 2020

Lots of broken tests?

@ericl ericl added the @author-action-required The PR author is responsible for the next step. Remove tag to send back to the reviewer. label Nov 11, 2020
@ijrsvt
Copy link
Contributor Author

ijrsvt commented Nov 12, 2020

Lots of broken tests?
Most of the failures were due to me making a really dumb error (autoscaler.constants instead of autoscaler._private.constants)

@ijrsvt ijrsvt added tests-ok The tagger certifies test failures are unrelated and assumes personal liability. and removed @author-action-required The PR author is responsible for the next step. Remove tag to send back to the reviewer. labels Nov 12, 2020
@ericl ericl merged commit 3b56a1a into ray-project:master Nov 13, 2020
This was referenced Dec 22, 2020
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericl ericl ericl approved these changes

Assignees

@ericl ericl

@AmeerHajAli AmeerHajAli

Labels
tests-ok The tagger certifies test failures are unrelated and assumes personal liability.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[autoscaler] restarting ray with ray up switches object store location from /dev/shm to /tmp
3 participants
@ijrsvt @ericl @AmeerHajAli