[tune] logger migration to ExperimentLogger classes #11984
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richardliaw
reviewed
Nov 12, 2020
richardliaw
reviewed
Nov 12, 2020
added 7 commits
November 16, 2020 10:46
…tion # Conflicts: # python/ray/tune/examples/wandb_example.py
krfricke
commented
Nov 16, 2020
| @@ -204,7 +204,7 @@ def on_result(self, result): | |||
| } | |||
| } | |||
| }) | |||
| self.assertTrue( | |||
| self.assertFalse( | |||
There was a problem hiding this comment.
I thought about this and I think it makes sense to never add any logger callbacks if someone sets the TUNE_DISABLE_AUTO_CALLBACK_LOGGERS env variable to 1. That's a deliberate choice and we shouldn't mess with that.
Before this PR there was a reason to add this (since we distinguished between legacy Logger classes and callbacks), but since we're moving to all-callbacks now, there's no need to do magic here.
richardliaw
reviewed
Nov 16, 2020
| @@ -249,7 +246,9 @@ def run( | |||
| trial (of ERROR state) when the experiments complete. | |||
| callbacks (list): List of callbacks that will be called at different | |||
| times in the training loop. Must be instances of the | |||
| ``ray.tune.trial_runner.Callback`` class. | |||
| ``ray.tune.trial_runner.Callback`` class. If not passed, | |||
There was a problem hiding this comment.
Suggested change
| ``ray.tune.trial_runner.Callback`` class. If not passed, | |
| ``ray.tune.callback.Callback`` class. If not passed, |
richardliaw
approved these changes
Nov 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Moves from
Loggerclasses toExperimentLoggerclasses.Todo:
tune.loggersRelated issue number
Checks
scripts/format.shto lint the changes in this PR.