Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[serve] Use Long Polling in Backend Worker #12093

Merged
merged 7 commits into from
Nov 25, 2020
Merged

[serve] Use Long Polling in Backend Worker #12093

merged 7 commits into from
Nov 25, 2020

Conversation

ijrsvt
Copy link
Contributor

@ijrsvt ijrsvt commented Nov 18, 2020 •
edited
Loading

Why are these changes needed?

Makes Serve Backend Workers Poll for Config Updates. This is part of the initiative started in #11905.

Related issue number

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@ijrsvt ijrsvt marked this pull request as ready for review November 20, 2020 17:52
@ijrsvt ijrsvt changed the title [WIP] backend-long-poll [serve] backend-long-poll Nov 23, 2020
simon-mo
simon-mo approved these changes Nov 23, 2020
View reviewed changes
Copy link
Contributor

@simon-mo simon-mo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's fix the comments and add a new tests as discussed offline

python/ray/serve/backend_worker.py Outdated Show resolved Hide resolved
python/ray/serve/controller.py Outdated Show resolved Hide resolved
edoakes
edoakes reviewed Nov 23, 2020
View reviewed changes
python/ray/serve/backend_worker.py Outdated Show resolved Hide resolved
python/ray/serve/backend_worker.py Show resolved Hide resolved
python/ray/serve/controller.py Outdated Show resolved Hide resolved
python/ray/serve/tests/test_backend_worker.py Outdated Show resolved Hide resolved
@ijrsvt ijrsvt added tests-ok The tagger certifies test failures are unrelated and assumes personal liability. and removed tests-ok The tagger certifies test failures are unrelated and assumes personal liability. labels Nov 24, 2020
@simon-mo simon-mo changed the title [serve] backend-long-poll [serve] Use Long Polling in Backend Worker Nov 25, 2020
@simon-mo simon-mo merged commit 679492a into ray-project:master Nov 25, 2020
@ericl
Copy link
Contributor

ericl commented Dec 1, 2020

This is 60% flaky in master for serve:test_api: https://flakey-tests.ray.io

@edoakes
Copy link
Contributor

edoakes commented Dec 1, 2020

Should be fixed here:
7022278

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edoakes edoakes edoakes left review comments

@simon-mo simon-mo simon-mo approved these changes

Assignees

@edoakes edoakes

@simon-mo simon-mo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ijrsvt @ericl @edoakes @simon-mo