[tune] detect docker and kubernetes syncers #12108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richardliaw
reviewed
Nov 18, 2020
richardliaw
reviewed
Nov 18, 2020
richardliaw
approved these changes
Nov 18, 2020
|
(just a small logging request... maybe we can do this in a separate PR, up to you) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Currently,
sync_to_driverassumes that defaultrsync-based syncers can be used to sync checkpoints and logs between workers and the driver. This PR adds functionality to automatically detect if it is running in a docker or kubernetes autoscaling environment and selects the appropriate syncer if detected.Related issue number
Closes https://discuss.ray.io/t/rsync-error-when-using-ray-tune/51
Checks
scripts/format.shto lint the changes in this PR.