Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[autoscaler] cover autofilling resources with try except. #12222

Merged
merged 79 commits into from
Nov 21, 2020
Merged

[autoscaler] cover autofilling resources with try except. #12222

merged 79 commits into from
Nov 21, 2020

Conversation

AmeerHajAli
Copy link
Contributor

solves #12195.

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Ameer Haj Ali and others added 30 commits September 24, 2020 00:26
prepare for head node
7248cf9
move command runner interface outside _private
bc43e46
Merge github.com:ray-project/ray
14be0a1
remove space
ab660a8
Eric
1ea0c1f
flake
dad31ae
Merge github.com:ray-project/ray
49bcf56
min_workers in multi node type
16d736d
Merge github.com:ray-project/ray
06911df
fixing edge cases
0d8dddb
eric not idle
fe69ce3
fix target_workers to consider min_workers of node types
35832ed
idle timeout
ca0be53
minor
c9518bd
minor fix
5452d39
test
9e904cd
lint
f9edcbe
eric v2
cb02267
eric 3
5e5d403
min_workers constraint before bin packing
4d44cd8
Merge github.com:ray-project/ray
614abbf
Update resource_demand_scheduler.py
818a63a
@wuisawesome
Revert "Update resource_demand_scheduler.py"
539b29c 
This reverts commit 818a63a.
reducing diff
9a63866
Merge branch 'master' of github.com:AmeerHajAli/ray
7501623
make get_nodes_to_launch return a dict
b4edd21
Merge github.com:ray-project/ray
fc48725
merge
0aef789
weird merge fix
39245a8
auto fill instance types for AWS
c7eb4ad
Ameer Haj Ali and others added 22 commits October 12, 2020 17:51
make logger of gc freed refs debug instead of info
b2b4cc0
Merge github.com:ray-project/ray
95ea031
add cluster name to docker mount prefix directory
1f000e5
grrR
d4253a2
fix tests
a195d6e
moving docker directory to sdk
7f05e7e
move the import to prevent circular dependency
2e16221
smallf fix
64595ec
ian
abaf4c7
Merge github.com:ray-project/ray
668898c
fix max launch concurrency bug to assume failing nodes as pending and…
4a3ea6a 
… consider only load_metric's connected nodes as running
small fix
1a2eb0b
Merge github.com:ray-project/ray
49069c7
@AmeerHajAli
Merge github.com:ray-project/ray
7b1a1b4
@AmeerHajAli
Merge github.com:ray-project/ray
6063cbb
@AmeerHajAli
Merge github.com:ray-project/ray
ab288c2
@AmeerHajAli
Merge github.com:ray-project/ray
ef9d144
@AmeerHajAli
make max_workers precede min_workers
ccf9a15
@AmeerHajAli
Merge github.com:ray-project/ray into max_workers
a6e9973
@AmeerHajAli
test
fa14df0
@AmeerHajAli
Merge github.com:ray-project/ray into boto3
49ad1f3
@AmeerHajAli
add exception
29ec01b
richardliaw
richardliaw requested changes Nov 21, 2020
View reviewed changes
Copy link
Contributor

@richardliaw richardliaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @AmeerHajAli for the fast turnaround. Can you please make the requested change, so that the first-time user does not need to see this scary stacktrace?

python/ray/autoscaler/_private/commands.py Outdated Show resolved Hide resolved
@AmeerHajAli
Copy link
Contributor Author

AmeerHajAli commented Nov 21, 2020 •
edited
Loading

I made the changes.
PS: author-action-required label would speedup the process.

@richardliaw
Copy link
Contributor

Thanks! i was asleep during that time anyways :)

richardliaw
richardliaw approved these changes Nov 21, 2020
View reviewed changes
Copy link
Contributor

@richardliaw richardliaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fast turnaround, Ameer!

@richardliaw richardliaw merged commit 2a9499a into ray-project:master Nov 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardliaw richardliaw richardliaw approved these changes

Assignees

@richardliaw richardliaw

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@AmeerHajAli @richardliaw @wuisawesome @ericl