Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[autoscaler] Raise node "start" deadline to 900s, make configurable #12316

Merged
merged 3 commits into from
Nov 24, 2020
Merged

[autoscaler] Raise node "start" deadline to 900s, make configurable #12316

merged 3 commits into from
Nov 24, 2020

Conversation

ericl
Copy link
Contributor

@ericl ericl commented Nov 23, 2020

Closes #12004

This is mostly in the case of docker-based node providers where the node launch may be delayed for a long time.

wuisawesome
wuisawesome approved these changes Nov 24, 2020
View reviewed changes
Copy link
Contributor

@wuisawesome wuisawesome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Btw any reason we don't make this a config option instead? Seems a bit annoying to have to set this env var when running ray up, then again when running ray start --head.

@ericl
Copy link
Contributor Author

ericl commented Nov 24, 2020

I think the main reasons is these vars should only be configured for debugging; like the others env vars in that file.

@ericl ericl merged commit 5895554 into ray-project:master Nov 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wuisawesome wuisawesome wuisawesome approved these changes

Assignees

@wuisawesome wuisawesome

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[autoscaler] Make NODE_START_WAIT_S configurable (for docker container nodes)
2 participants
@ericl @wuisawesome