Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RLlib] Issue 11591: SAC loss does not use PR-weights in critic loss term. #12394

Merged
merged 2 commits into from
Nov 25, 2020
Merged

[RLlib] Issue 11591: SAC loss does not use PR-weights in critic loss term. #12394

merged 2 commits into from
Nov 25, 2020

Conversation

sven1977
Copy link
Contributor

Issue 11591: SAC loss does not use PR-weights in critic loss term.

Why are these changes needed?

Closes #11591

Closes #11591

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@sven1977 sven1977 requested a review from ericl November 25, 2020 08:53
@sven1977 sven1977 mentioned this pull request Nov 25, 2020
Closed
@ericl ericl merged commit b7dbbfb into ray-project:master Nov 25, 2020
@sven1977 sven1977 deleted the issue_11591_sac_loss_not_multiplied_by_pr_weights branch June 2, 2023 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericl ericl ericl approved these changes

Assignees

@ericl ericl

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[rllib] SAC does not multiply importance weights when calculating loss
2 participants
@sven1977 @ericl