Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SGD] Add PTL Docs #12440

Merged
merged 59 commits into from
Nov 28, 2020
Merged

[SGD] Add PTL Docs #12440

merged 59 commits into from
Nov 28, 2020

Conversation

amogkam
Copy link
Contributor

@amogkam amogkam commented Nov 26, 2020

Long overdue LightningOperator documentation

image
image
image
image
image
image

Why are these changes needed?

Related issue number

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

amogkam and others added 30 commits August 24, 2020 10:18
@amogkam
wip
f92a425
@amogkam
wip
05c2e96
@amogkam
adding dcgan example
b9709c5
@amogkam
wip
10d13ca
@richardliaw
Merge branch 'master' into sgd-local
aa20414
@amogkam
updates
6ae24de
@amogkam
updates
9ca3c6f
@amogkam
Merge branch 'sgd-local' of github.com:amogkam/ray into sgd-local
6e97f83
@amogkam
test_torch_runner all passing
2131244
@amogkam
test torch wip
2f27aa6
@amogkam
test_torch
c2a9aa0
@amogkam
examples
fc62423
@amogkam
docs
6f2abed
@amogkam
formatting
2225964
@amogkam
address comment
b160521
@amogkam
update cifar example
04c11a8
@amogkam
update example
b46e3f0
@amogkam
doc fixes
4b33fa9
@amogkam
make separate abstract class
1aeee7d
@amogkam
add errors and doc warning
6e1e652
@amogkam
make abstact class and fix test
941ec1f
@amogkam
formatting
be17147
@amogkam
wip
accd855
@amogkam
Merge branch 'master' of https://github.com/ray-project/ray into sgd-ptl
8ac38fc
@amogkam
wip
417970f
@amogkam
wip
c182ded
@amogkam
wip
deceae5
@amogkam
Merge branch 'master' of https://github.com/ray-project/ray into sgd-ptl
87519b5
@amogkam
wip
fd8ac8e
@amogkam
Merge branch 'master' of https://github.com/ray-project/ray into sgd-ptl
4f68fdf
richardliaw
richardliaw requested changes Nov 26, 2020
View reviewed changes
Copy link
Contributor

@richardliaw richardliaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good, but we should avoid introducing pytorch-lightning as a dependency for the doc build.

Also, there were a couple errors when i tried building myself.

@amogkam
Copy link
Contributor Author

amogkam commented Nov 26, 2020

@richardliaw I addressed all the comments

@richardliaw richardliaw merged commit 8a406e1 into ray-project:master Nov 28, 2020
@richardliaw
Copy link
Contributor

nice work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardliaw richardliaw richardliaw approved these changes

Assignees

@richardliaw richardliaw

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@amogkam @richardliaw