Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[autoscaler] Try to improve the request_resources() documentation #12465

Merged
merged 7 commits into from
Dec 1, 2020
Merged

[autoscaler] Try to improve the request_resources() documentation #12465

merged 7 commits into from
Dec 1, 2020

Conversation

ericl
Copy link
Contributor

@ericl ericl commented Nov 27, 2020

Closes #12443

@AmeerHajAli AmeerHajAli added the @author-action-required The PR author is responsible for the next step. Remove tag to send back to the reviewer. label Nov 29, 2020
@AmeerHajAli
Copy link
Contributor

Added 1 comment, lets see if @wuisawesome is comfortable with the documentation.

wuisawesome
wuisawesome approved these changes Nov 30, 2020
View reviewed changes
Copy link
Contributor

@wuisawesome wuisawesome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, the example is super helpful

@ericl ericl merged commit 234df90 into ray-project:master Dec 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wuisawesome wuisawesome wuisawesome approved these changes

@AmeerHajAli AmeerHajAli AmeerHajAli approved these changes

Assignees

@wuisawesome wuisawesome

@AmeerHajAli AmeerHajAli

Labels
@author-action-required The PR author is responsible for the next step. Remove tag to send back to the reviewer.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[autoscaler] Request resources behaves inconsistently
3 participants
@ericl @AmeerHajAli @wuisawesome